From 4a361053b5947fa209fadd9d95cc9213e4052e31 Mon Sep 17 00:00:00 2001 From: reshke Date: Thu, 4 Apr 2024 20:50:54 +0000 Subject: [PATCH v1] Point comments needed to be edited --- contrib/pg_visibility/pg_visibility.c | 1 + src/backend/access/transam/xact.c | 1 + src/backend/storage/ipc/standby.c | 1 + 3 files changed, 3 insertions(+) diff --git a/contrib/pg_visibility/pg_visibility.c b/contrib/pg_visibility/pg_visibility.c index cb0c49c7a4..c5f46a3fc7 100644 --- a/contrib/pg_visibility/pg_visibility.c +++ b/contrib/pg_visibility/pg_visibility.c @@ -548,6 +548,7 @@ collect_visibility_data(Oid relid, bool include_pd) * databases that were ignored before. * 2. Ignore KnownAssignedXids, because they are not database-aware. At the * same time, the primary could compute its horizons database-aware. + * XXX: KnownAssignedXids is gone so the above comment needs updating. * 3. Ignore walsender xmin, because it could go backward if some replication * connections don't use replication slots. * diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 5456954602..c81b9362e2 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -1378,6 +1378,7 @@ RecordTransactionCommit(void) * KnownAssignedXids machinery requires tracking every XID assignment. It * might be OK to skip it only when wal_level < replica, but for now we * don't.) + * XXX: KnownAssignedXids is gone so the above comment needs updating. * * However, if we're doing cleanup of any non-temp rels or committing any * command that wanted to force sync commit, then we must flush XLOG diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c index 078ed53acd..a5d8a846cd 100644 --- a/src/backend/storage/ipc/standby.c +++ b/src/backend/storage/ipc/standby.c @@ -1267,6 +1267,7 @@ standby_redo(XLogReaderState *record) * an entry are expected and must not cause an error when we are in state * STANDBY_INITIALIZED. This is implemented in StandbyReleaseLocks() and * KnownAssignedXidsRemove(). + * XXX: KnownAssignedXids is gone so the above comment needs updating. * * Later, when we apply the running xact data we must be careful to ignore * transactions already committed, since those commits raced ahead when -- 2.25.1