From abc993eb92e5839589652d42d979a3318bfc0c08 Mon Sep 17 00:00:00 2001 From: Masahiko Sawada Date: Mon, 25 Nov 2024 21:29:07 -0800 Subject: [PATCH v3 1/2] Remove inclusion of fundamental header files from some header files. This commit removes fundamental header files such as "c.h" and "postgres.h" from some header files since it's against our usual convention. Reported-by: Tom Lane Reviewed-by: Heikki Linnakangas Discussion: https://postgr.es/m/CAD21AoCU9YH%2Bb9Rr8YRw7UjmB%3D1zh8GKQkWNiuN9mVhMvkyrRg%40mail.gmail.com --- src/bin/pg_combinebackup/copy_file.h | 1 - src/include/fe_utils/option_utils.h | 2 -- src/include/fe_utils/query_utils.h | 2 -- 3 files changed, 5 deletions(-) diff --git a/src/bin/pg_combinebackup/copy_file.h b/src/bin/pg_combinebackup/copy_file.h index d5ddc7e53d7..ecc1f3fc7ef 100644 --- a/src/bin/pg_combinebackup/copy_file.h +++ b/src/bin/pg_combinebackup/copy_file.h @@ -11,7 +11,6 @@ #ifndef COPY_FILE_H #define COPY_FILE_H -#include "c.h" #include "common/checksum_helper.h" /* diff --git a/src/include/fe_utils/option_utils.h b/src/include/fe_utils/option_utils.h index afd108fdabf..ff1d22459d3 100644 --- a/src/include/fe_utils/option_utils.h +++ b/src/include/fe_utils/option_utils.h @@ -12,8 +12,6 @@ #ifndef OPTION_UTILS_H #define OPTION_UTILS_H -#include "postgres_fe.h" - #include "common/file_utils.h" typedef void (*help_handler) (const char *progname); diff --git a/src/include/fe_utils/query_utils.h b/src/include/fe_utils/query_utils.h index 9a680d5bffe..e7403d9cbd4 100644 --- a/src/include/fe_utils/query_utils.h +++ b/src/include/fe_utils/query_utils.h @@ -12,8 +12,6 @@ #ifndef QUERY_UTILS_H #define QUERY_UTILS_H -#include "postgres_fe.h" - #include "libpq-fe.h" extern PGresult *executeQuery(PGconn *conn, const char *query, bool echo); -- 2.43.5