From: | "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, <t-ishii(at)sra(dot)co(dot)jp> |
Cc: | <pgsql-patches(at)postgreSQL(dot)org> |
Subject: | RE: Important 7.0.* fix to ensure buffers are released |
Date: | 2000-09-05 08:51:15 |
Message-ID: | 001701c017163beb8001007e@tpf.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> -----Original Message-----
> From: Tom Lane
>
> t-ishii(at)sra(dot)co(dot)jp writes:
> > Interesting thing is that 6.5.x does not have the problem. Is it new
> > one for 7.0.x?
>
> I think the bug has been there for a long time. It is easier to see
One of the reason why we see the bug often in 7.0 seems to be
the following change which was applied to temprel.c before 7.0.
remove_all_temp_relations() always called AbortOutAnyTransaction()
before the change. remove_all_temp_relations() has been called from
shmem_exit() and accidentally(I don't think it had been intensional)
proc_exit() always called AbortOutAnyTransaction().
@@ -79,6 +79,9 @@
List *l,
*next;
+ if (temp_rels == NIL)
+ return;
+
AbortOutOfAnyTransaction();
StartTransactionCommand();
Regards.
Hiroshi Inoue
From | Date | Subject | |
---|---|---|---|
Next Message | Finn Kettner | 2000-09-05 13:56:36 | Visual Studio 6 project/workspace files |
Previous Message | Chris | 2000-09-04 22:51:34 | Re: OO inheritance implementation |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2000-09-05 13:57:01 | Re: Important 7.0.* fix to ensure buffers are released |
Previous Message | t-ishii | 2000-09-04 11:29:36 | Re: Re: [PATCHES] Important 7.0.* fix to ensure buffers are released |