| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Hash join explain is broken |
| Date: | 2019-07-02 14:50:02 |
| Message-ID: | 10856.1562079002@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> Tom, any comments? Otherwise I'll go ahead, and commit after a round or
>> two of polishing.
> Sorry for not getting to this sooner --- I'll try to look tomorrow.
I took a look, and I think this is going in the right direction.
We definitely need a test case corresponding to the live bug,
and I think the comments could use more work, and there are some
cosmetic things (I wouldn't add the new struct Hash field at the
end, for instance).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-02 15:09:17 | Re: [PATCH] Implement uuid_version() |
| Previous Message | Rui Hai Jiang | 2019-07-02 14:47:32 | TopoSort() fix |