| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jan Urbański <j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords |
| Date: | 2007-11-14 03:50:41 |
| Message-ID: | 13005.1195012241@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> + defstring = defGetString(defel);
> + if (pg_strcasecmp(defstring, "True") == 0)
> + d->acceptAll = true;
> + else if (pg_strcasecmp(defstring, "False") == 0)
> + d->acceptAll = false;
> + else
> + ereport(ERROR,
> + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> + errmsg("invalid value for AcceptAll parameter: \"%s\"",
> + defstring)));
This bit should be replaced with defGetBoolean. Otherwise it looks
reasonably sane.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2007-11-14 04:38:08 | Better default_statistics_target |
| Previous Message | Tom Lane | 2007-11-14 03:34:37 | Re: Simplifying Text Search |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2007-11-14 04:38:08 | Better default_statistics_target |
| Previous Message | Andrew Dunstan | 2007-11-14 03:03:40 | Re: [HACKERS] plperl and regexps with accented characters - incompatible? |