| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Miscalculation in IsCheckpointOnSchedule() |
| Date: | 2007-11-14 05:32:14 |
| Message-ID: | 14221.1195018334@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> - ((double) (int32) (recptr.xrecoff - ckpt_start_recptr.xrecoff)) / XLogSegSize) /
> + ((double) recptr.xrecoff - (double) ckpt_start_recptr.xrecoff) / XLogSegSize) /
Surely this makes matters worse, not better. What happens near a segment
boundary crossing?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-11-14 05:37:26 | Re: [HACKERS] plperl and regexps with accented characters - incompatible? |
| Previous Message | ITAGAKI Takahiro | 2007-11-14 05:26:12 | Miscalculation in IsCheckpointOnSchedule() |