| From: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql -f doesn't complain about directories |
| Date: | 2007-11-14 20:19:41 |
| Message-ID: | 20071114201941.GB13620@svana.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 14, 2007 at 05:15:20PM -0300, Alvaro Herrera wrote:
> > Should we do some kind of stat() before opening the file and abort if it's a
> > directory?
>
> Actually anything other than a plain file, right? (Do we really want to
> be able to psql -f a_pipe?)
Sure, why not. To be honest I think that psql shouldn't be ignoring the
EISDIR error the kernel is returning.
Have a nice day,
--
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Those who make peaceful revolution impossible will make violent revolution inevitable.
> -- John F Kennedy
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zdenek Kotala | 2007-11-14 20:33:17 | Re: psql -f doesn't complain about directories |
| Previous Message | Andrew Dunstan | 2007-11-14 20:18:45 | Re: psql -f doesn't complain about directories |