| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Mark Cave-Ayland <mark(dot)cave-ayland(at)siriusit(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP patch: reducing overhead for repeat de-TOASTing |
| Date: | 2008-07-02 15:05:44 |
| Message-ID: | 20080702150544.GS18252@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> It would be simple enough to fix nodeSubplan.c to copy the data into
> an upper-level Slot rather than a bare tuple. But this makes me wonder
> how many other places are like this. In the past there wasn't that much
> benefit to pulling data from a Slot instead of a bare tuple, so I'm
> afraid we might have a number of similar gotchas we'd have to track
> down.
I compare this to adding CHECK_FOR_INTERRUPTS(): let's declare that
every usage of bare tuples is a not-very-serious bug, and we can fix
them one by one as we come across them.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-07-02 15:10:37 | Re: pg crashing |
| Previous Message | Magnus Hagander | 2008-07-02 14:43:11 | Re: pg crashing |