| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_archivecleanup bug |
| Date: | 2014-03-18 18:42:44 |
| Message-ID: | 20140318184244.GX6899@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | Postg배트맨 토토SQL |
Bruce Momjian escribió:
> On Tue, Mar 18, 2014 at 06:11:30PM +0000, Simon Riggs wrote:
> > On 18 March 2014 18:01, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > On Tue, Mar 18, 2014 at 04:17:53PM +0000, Simon Riggs wrote:
> > >> > While I am not a fan of backpatching, the fact we are ignoring errors in
> > >> > some critical cases seems the non-cosmetic parts should be backpatched.
> > >>
> > >> pg_resetxlog was not an offender here; its coding was sound.
> > >>
> > >> We shouldn't be discussing backpatching a patch that contains changes
> > >> to coding style.
> > >
> > > I was going to remove the coding style changes to pg_resetxlog from the
> > > backpatched portion.
> >
> > Why make style changes at all? A patch with no style changes would
> > mean backpatch and HEAD versions would be the same.
>
> The old style had errno set in two places in the loop, while the new
> style has it set in only one place.
I think it makes more sense to have all callsites look the same in all
supported branches.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2014-03-18 18:47:25 | Re: pg_archivecleanup bug |
| Previous Message | Tom Lane | 2014-03-18 18:41:59 | Re: Risk Estimation WAS: Planner hints in Postgresql |