| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: Unsafe coding in ReorderBufferCommit() |
| Date: | 2015-01-26 10:52:05 |
| Message-ID: | 20150126105205.GA9916@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tom,
On 2015-01-23 16:47:30 -0500, Tom Lane wrote:
> There are at least two bugs in reorderbuffer.c's ReorderBufferCommit():
Thanks for fixing these!
Unfortunately there's more - we'll currently do bad things if
transaction commit fails. At the very least the (sub-)transaction begin
commands need to be moved out of the exception block as they can
fail... :(. E.g. because this is the 2^32-1 subxact or similar...
I actually also want to strip the CATCH block of most of it's contents -
there's really no need anymore for most of what it does.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-01-26 11:03:17 | Re: longjmp clobber warnings are utterly broken in modern gcc |
| Previous Message | Andres Freund | 2015-01-26 10:20:57 | Re: basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe? |