| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: What exactly is our CRC algorithm? |
| Date: | 2015-02-09 13:20:46 |
| Message-ID: | 20150209132046.GA20362@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2015-02-09 12:52:41 +0200, hlinnakangas(at)vmware(dot)com wrote:
>
> Ok, I've committed a patch that just moves the existing code to
> common/pg_crc.c […]
Thanks, looks good.
> Attached is a rebased version of the slicing-by-8 patch.
Looks OK too.
> Do you have access to big-endian hardware to test this on?
Yes, I tested it on a Linux/ppc system. I wasn't speculating when I said
it "does make a noticeable difference", though I'm afraid I did not keep
the timings after submitting the revised patch. The speedup was some
double-digit percentage, IIRC.
-- Abhijit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Syed, Rahila | 2015-02-09 13:27:33 | Re: [REVIEW] Re: Compression of full-page-writes |
| Previous Message | Hakan Kocaman | 2015-02-09 12:13:00 | Re: For cursors, there is FETCH and MOVE, why no TELL? |