| From: | Tomasz Rybak <tomasz(dot)rybak(at)post(dot)pl> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pglogical_output - a general purpose logical decoding output plugin |
| Date: | 2016-01-18 21:47:27 |
| Message-ID: | 20160118214727.1300.55757.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | Postg토토 베이SQL |
I just quickly went through patch v5.
It's rather big patch, on (or beyond) my knowledge of PostgreSQL to perform high-quality review. But during this week I'll try to send reviews of parts of the code, as going through it in one sitting seems impossible.
One proposed change - update copyright to 2016.
i'd also propose to change of pglogical_output_control.in:
comment = 'general purpose logical decoding plugin'
to something like "general-purpoer plugin decoding and generating stream of logical changes"
We might also think about changing name of plugin to something resembling "logical_streaming_decoder" or even "logical_streamer"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-01-18 21:48:00 | Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types |
| Previous Message | Tomasz Rybak | 2016-01-18 21:47:06 | Re: pglogical_output - a general purpose logical decoding output plugin |