| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi |
| Cc: | pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #14468: One byte buffer overlow in quote_literal_cstr() |
| Date: | 2016-12-16 14:43:51 |
| Message-ID: | 20161216144351.apdbuk4je5ywekle@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
hlinnaka(at)iki(dot)fi wrote:
> Looking at quote_literal_cstr(), it simply doesn't take into account the
> space needed for the NULL terminator, when it allocates the buffer. The fix
> is a straightforward + 1 to the allocation. I'll go and do that shortly, and
> backpatch.
Hm, that's a bit confusing. I thought the +3 included the terminator,
but what it's actually for is the optional starting E; and the reason
quote_literal doesn't need similar patching it is that there is no
terminator 'cause it produces varlena. I would think this deserves a
comment ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Janes | 2016-12-16 20:47:03 | Re: pg_dump's results have quite different size |
| Previous Message | hlinnaka | 2016-12-16 10:50:01 | BUG #14468: One byte buffer overlow in quote_literal_cstr() |