| From: | Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
| Subject: | Re: tuplesort_gettuple_common() and *should_free argument |
| Date: | 2017-04-05 13:07:58 |
| Message-ID: | 20170405130758.27610.3888.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
The patch looks fine to me. Changes are clear and all functions are commented properly.
So I marked it "Ready for committer".
The new status of this patch is: Ready for Committer
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-04-05 13:19:31 | Re: strange parallel query behavior after OOM crashes |
| Previous Message | Arthur Zakirov | 2017-04-05 13:06:04 | Re: [PATCH] Generic type subscripting |