| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | bianpan2016(at)163(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: BUG #15105: OpenTransientFile() should be paired with CloseTransientFile() rather than close() |
| Date: | 2018-04-11 03:30:24 |
| Message-ID: | 20180411032917.GK26769@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Apr 10, 2018 at 06:40:43PM -0400, Tom Lane wrote:
> On closer inspection, such a cross-check wouldn't have helped find this
> particular mistake, because it was in an error exit path that's likely
> never been exercised by anybody, and certainly isn't hit in the regression
> tests. Still, I think it'd be a good thing to add, and hence propose the
> attached patch. (I've verified that the warning doesn't fire in "make
> check-world".)
Good idea. +1 for your proposed patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2018-04-11 04:10:29 | Re: power() function in Windows: "value out of range: underflow" |
| Previous Message | David Rowley | 2018-04-11 03:13:35 | Re: power() function in Windows: "value out of range: underflow" |