| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, exclusion(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Subject: | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
| Date: | 2019-03-20 09:17:27 |
| Message-ID: | 20190320091727.GE26601@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs 503 윈 토토 페치 실패 |
On Wed, Mar 20, 2019 at 06:07:23PM +0900, Amit Langote wrote:
> because we can notice the aggregate before we look into its arguments.
> Maybe, we should move the error-checking switch to a point before checking
> the arguments? That looks slightly more drastic change to make though.
Yeah, I think that it would be more invasive because the parsing logic
looks at the column references first. This way of doing things is
also something which is logic in its own way as the most internal
portions of an expression get checked first, so I quite like that way
of doing things. And that's just consistent with the point of view of
the parsing check order.
> We may want to fix the crash first. It might be better to hear other
> opinions before doing something about the error messages.
The thing is that in order to keep the tests for the crash, we finish
with the inintuitive RTE-related errors, so it is also inconsistent to
not group things..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-03-20 11:43:26 | Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name |
| Previous Message | Amit Langote | 2019-03-20 09:07:23 | Re: BUG #15668: Server crash in transformPartitionRangeBounds |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-03-20 09:38:36 | Re: Offline enabling/disabling of data checksums |
| Previous Message | Amit Langote | 2019-03-20 09:07:23 | Re: BUG #15668: Server crash in transformPartitionRangeBounds |