| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | david(at)pgmasters(dot)net, michael(dot)banck(at)credativ(dot)de, pgsql-hackers(at)postgresql(dot)org, sfrost(at)snowman(dot)net |
| Subject: | Re: [Patch] Make pg_checksums skip foreign tablespace directories |
| Date: | 2020-02-23 07:08:58 |
| Message-ID: | 20200223070858.GB1792@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 21, 2020 at 05:37:15PM +0900, Kyotaro Horiguchi wrote:
> The two str[n]cmps are different only in matching length. I don't
> think we don't need to differentiate the two message there, so we
> could reduce the code as:
>
> | cmplen = strlen(excludeFiles[].name);
> | if (!prefix_patch)
> | cmplen++;
> | if (strncmp(d_name, excludeFilep.name, cmplen) == 0)
> | ...
Good idea. Let's do things as you suggest.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| exclude-prefix-filter-v3.patch | text/x-diff | 10.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-02-23 07:12:57 | Re: [Patch] Make pg_checksums skip foreign tablespace directories |
| Previous Message | Shay Rojansky | 2020-02-23 05:40:58 | Re: Error on failed COMMIT |