From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Atsushi Torikoshi <atorik(at)gmail(dot)com> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: add types to index storage params on doc |
Date: | 2020-03-16 14:32:50 |
Message-ID: | 20200316143250.GA15010@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | Postg메이저 토토 사이트SQL |
On 2020-Mar-16, Atsushi Torikoshi wrote:
> Thanks for your comments!
>
> On Mon, Mar 16, 2020 at 11:49 AM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
> wrote:
>
> > - <term><literal>buffering</literal>
> > + <term><literal>buffering</literal> (<type>string</type>)
> >
> > Isn't it better to use "enum" rather than "string"?
> > In the docs about enum GUC parameters, "enum" is used there.
>
> Agreed. I've fixed it to "enum".
>
> But I'm now wondering about the type of check_option[3], [4].
> Because I decide the type to "string" referring to check_option, which is
> the other element of enumRelOpts in reloptions.c.
>
> Should I also change it to "enum"?
Yeah, these were strings until recently (commit 773df883e8f7 Sept 2019).
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2020-03-16 14:43:12 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
Previous Message | Tom Lane | 2020-03-16 14:32:36 | Re: Refactor compile-time assertion checks for C/C++ |