Re: BUG #17646: create rule named "_RETURN" will cause pg core

On Mon, Oct 17, 2022 at 10:41:35AM -0400, Tom Lane wrote:
> Ilya Anfimov <ilan(at)tzirechnoy(dot)com> writes:
> > On Mon, Oct 17, 2022 at 10:17:55AM -0400, Tom Lane wrote:
> >> (Although the core dump is also not great --- something should've noticed
> >> the bogosity of the plan earlier than this.)
>
> > Id doesn't look much of a plan bogosity,
> > but rather implicit deletion of the "_RETURN" on select rule.
>
> Right, but then since there's no applicable rule, we end up generating
> a plan that tries to do a seqscan directly on the view relation,
> which of course lacks storage. Something should notice that a little
> sooner than segfaulting because of rel->rd_tableam being NULL --- it's
> not like we don't have hundreds of other sanity checks for not-really-
> supposed-to-happen catalog corruption.
>
> In versions before v12, I get something like
>
> regression=# select * from v1;
> ERROR: could not open file "base/16384/49209": No such file or directory
>
> which is a shade less bad, but still not great.

Another solution would be to always create a real heap file and let
anyone dropped to that state select it, if he wishes.

btw, the documentation clearly says that it does so:
/docs/14/rules-views.html

<<In fact, there is essentially no difference between:

CREATE VIEW myview AS SELECT * FROM mytab;
compared against the two commands:

CREATE TABLE myview (same column list as mytab);
CREATE RULE "_RETURN" AS ON SELECT TO myview DO INSTEAD
SELECT * FROM mytab;
because this is exactly what the CREATE VIEW command does internally. >>