Re: pg_rewind WAL segments deletion pitfall

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Alexander Kukushkin <cyberdemn(at)gmail(dot)com>
Cc: Sutou Kouhei <kou(at)clear-code(dot)com>, smithpb2250(at)gmail(dot)com, torikoshia(at)oss(dot)nttdata(dot)com, horikyota(dot)ntt(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org, bungina(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_rewind WAL segments deletion pitfall
Date: 2024-11-12 19:18:30
Message-ID: 202411121918.beiyanf6gfnb@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs Postg토토 베이SQL

Hello

After reading the whole thread a couple of times to make sure I
understood the problem correctly, I think the approach in the v10 patch
is a reasonable one. I agree that it's better for maintainability to
keep a separate hash table. I made some cosmetic adjustments -- didn't
find any fault in the code. I also verified that the test is hitting
the problematic case.

So here's v11, which I'll try to get out tomorrow.

I also assessed back-patching this. There's some conflicts, but nothing
serious, back to 14. Unfortunately, 13 lacks requisite infrastructure,
so I think it'll have to stay as it is. (12 is dead.)

Can you please verify that my explanation in the commit message is
sound?

Thanks

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Cada quien es cada cual y baja las escaleras como quiere" (JMSerrat)

Attachment Content-Type Size
v11-0001-Be-more-picky-with-WAL-segment-deletion-in-pg_re.patch text/x-diff 10.0 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Davis 2024-11-12 23:15:55 Re: HashAgg degenerate case
Postg스포츠 토토SQL : Andres Freund 2024-11-12 15:48:31 Postg스포츠 토토SQL : 스포츠 토토 : Hashagg

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-11-12 19:50:11 Re: logical replication: restart_lsn can go backwards (and more), seems broken since 9.4
Previous Message Alvaro Herrera 2024-11-12 19:11:07 Re: Fix array access (src/bin/pg_dump/pg_dump.c)