Re: pgsql: Add a note about another issue that needs to be considered before

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> FWIW I found another issue with this variable when I was experimenting with
> small block sizes. If you set the target <= the tuple header the toaster
> breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I
> think the right solution is just to change it to use plain int32 arithmetic
> everywhere.

Somehow I can't get excited about that. If we ever do open things up to
allow user control of the target, we'd certainly constrain it to a sane
range.

regards, tom lane