| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small patch: fix code duplication in heapam.c |
| Date: | 2016-03-24 14:08:48 |
| Message-ID: | 22609.1458828528@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | Postg토토 커뮤니티SQL |
Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> writes:
> I discovered that there is a lot of code duplication in heapam.c.
> In particular relation_openrv and relation_openrv_extended procedures
> and also heap_openrv and heap_openrv_extended procedures are almost the
> same. Here is a patch that fixes this.
As with that other patch to refactor palloc-related stuff, I'm not
convinced that this is an improvement. All that code is hotspot stuff,
and turning it into a pile of nested procedures doesn't seem like it
improves either performance or readability.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-03-24 14:14:06 | Re: Re: Missing rows with index scan when collation is not "C" (PostgreSQL 9.5) |
| Previous Message | Robert Haas | 2016-03-24 14:03:42 | Re: 2PC support for pglogical |