| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, sindysenorita(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17618: unnecessary filter column <> text even after adding index |
| Date: | 2022-11-05 17:07:44 |
| Message-ID: | 2616649.1667668064@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> Update with v3 patch, nothing changes except fixes a test failure
> spotted by cfbot.
I think this is pretty close to usable, except that I don't believe
reusing simplify_boolean_equality this way is a great idea.
It does more than we need (surely the LHS-is-Const case cannot occur here)
and it has assumptions that I'm not sure hold --- particularly the bit
about !constisnull. I'd be inclined to just copy-and-paste the three or
four lines we need.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-05 17:23:20 | Re: BUG #17618: unnecessary filter column <> text even after adding index |
| Previous Message | Tom Lane | 2022-11-04 19:07:02 | Re: BUG #17233: Incorrect behavior of DELETE command with bad subquery in WHERE clause |