From: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
---|---|
To: | Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> |
Cc: | pgsql-hackers(at)postgresql(dot)org, grzm(at)myrealbox(dot)com |
Subject: | Re: Use of 8192 as BLCKSZ in xlog.c |
Date: | 2005-11-22 03:59:46 |
Message-ID: | 438297B2.9040305@paradise.net.nz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Qingqing Zhou wrote:
> "Mark Kirkwood" <markir(at)paradise(dot)net(dot)nz> wrote
>
>>In two of the sections covered by #ifdef WAL_DEBUG there are declarations
>>like:
>>
>>char buf[8192];
>
>
>
> Those two 8192 have nothing to do with BLCKSZ, it is just an arbitrary
> buffer size as long as it is big enough to hold debug information.
>
Thanks - of course, different sort of buffer!
It is a bit more obvious now that I'm running with WAL_DEBUG enabled,
and can see that nature of the output. As has been suggested, maybe a
comment about the size and nature of 'buf' might be a nice addition.
cheers
Mark
From | Date | Subject | |
---|---|---|---|
Next Message | Bob Ippolito | 2005-11-22 04:17:39 | Re: PostgreSQL 8.1.0 catalog corruption |
Previous Message | Joshua D. Drake | 2005-11-22 03:31:53 | Re: Bug in predicate indexes? |