| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, Amit Khandekar <amit(dot)khandekar(at)enterprisedb(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] introduce XLogLockBlockRangeForCleanup() |
| Date: | 2014-08-20 08:07:44 |
| Message-ID: | 53F45750.70409@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/07/2014 11:46 AM, Abhijit Menon-Sen wrote:
> At 2014-07-07 14:02:15 +0530, amit(dot)khandekar(at)enterprisedb(dot)com wrote:
>>
>> Other than some minor comments as mentioned below, I don't have any
>> more issues, it looks all good.
>
> Thank you. (Updated patch attached.)
I don't think the new GetBufferWithoutRelcache function is in line with
the existing ReadBuffer API. I think it would be better to add a new
ReadBufferMode - RBM_CACHE_ONLY? - that only returns the buffer if it's
already in cache, and InvalidBuffer otherwise.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-08-20 08:50:06 | Re: August commitfest |
| Previous Message | Heikki Linnakangas | 2014-08-20 08:03:23 | Re: August commitfest |