From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
---|---|
To: | Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
Subject: | Re: WIP Patch for GROUPING SETS phase 1 |
Date: | 2014-08-21 06:32:36 |
Message-ID: | 53F59284.1050801@vmware.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 08/13/2014 09:43 PM, Atri Sharma wrote:
> Sorry, forgot to attach the patch for fixing cube in contrib, which breaks
> since we now reserve "cube" keyword. Please find attached the same.
Ugh, that will make everyone using the cube extension unhappy. After
this patch, they will have to quote contrib's cube type and functions
every time.
I think we should bite the bullet and rename the extension, and its
"cube" type and functions. For an application, having to suddenly quote
it has the same effect as renaming it; you'll have to find all the
callers and change them. And in the long-run, it's clearly better to
have an unambiguous name.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Haribabu Kommi | 2014-08-21 06:47:01 | Parallel Sequence Scan doubts |
Previous Message | Haribabu Kommi | 2014-08-21 05:59:16 | Implementing parallel sequence doubts |