| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: GiST for range types (was Re: Range Types - typo + NULL string constructor) |
| Date: | 2011-11-02 19:48:22 |
| Message-ID: | 6217.1320263302@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> writes:
> On 01.11.2011 06:33, Jeff Davis wrote:
>> + else if (lower1.infinite || upper1.infinite)
>> + length1 = 1.0/0.0;
> That seems wrong. I take it that the point is to set length1 to infinity?
Please use get_float[48]_infinity() or get_float[48]_nan(), as
appropriate (I think the latter may be intended here), rather than
making up your own way of getting those values.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2011-11-02 19:48:43 | Re: Re: [COMMITTERS] pgsql: Reduce checkpoints and WAL traffic on low activity database serv |
| Previous Message | Heikki Linnakangas | 2011-11-02 19:29:31 | Re: GiST for range types (was Re: Range Types - typo + NULL string constructor) |