| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tom Raney <twraney(at)comcast(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Hash Index Build Patch v2 |
| Date: | 2008-03-16 23:23:27 |
| Message-ID: | 7368.1205709807@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Raney <twraney(at)comcast(dot)net> writes:
> This revised version of our patch uses the function estimate_rel_size()
> from plancat.c to estimate the number of tuples in the parent relation.
> This method is an alternative to scanning the parent relation to
> estimate the number of tuples, as we did in the first version of the patch.
Applied after significant editorialization. You need to pay more
attention to conforming to the style of the surrounding code and to
updating comments that your work renders inaccurate.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-03-17 00:33:47 | Re: sinval.c / sinvaladt.c restructuring |
| Previous Message | Peter Eisentraut | 2008-03-14 21:18:22 | Re: Suppress compiler warnings on mingw |