| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [PATCH 1/5] Centralize Assert* macros into c.h so its common between backend/frontend |
| Date: | 2013-01-18 15:43:06 |
| Message-ID: | 7711.1358523786@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> One slight problem with this is the common port/*.c idiom would require
> an extra include:
> #ifndef FRONTEND
> #include "postgres.h"
> #else
> #include "postgres_fe.h"
> #include "pgassert.h" /* <--- new line required here */
> #endif /* FRONTEND */
> If this is seen as a serious issue (I don't think so) then we would have
> to include pgassert.h into postgres_fe.h which would make the whole
> thing pointless (i.e. the same as just having the definitions in c.h).
We'd only need to add that when/if the file started to use asserts,
so I don't think it's a problem. But still not sure it's better than
just putting the stuff in c.h.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-01-18 15:47:32 | Re: Event Triggers: adding information |
| Previous Message | Merlin Moncure | 2013-01-18 15:36:03 | Re: WIP patch for hint bit i/o mitigation |