| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Jeroen Vermeulen <jtvjtv(at)gmail(dot)com> |
| Cc: | pgsql-interfaces(at)postgresql(dot)org |
| Subject: | Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()? |
| Date: | 2024-12-21 15:56:31 |
| Message-ID: | 859822.1734796591@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-interfaces |
Jeroen Vermeulen <jtvjtv(at)gmail(dot)com> writes:
> Any objections to changing these two libpq functions' PGresult* parameters
> to be const?
> So "char * PQcmdStatus(PGresult *)" would become "char *PQcmdStatus(const
> PGresult *)", and "char *PQcmdTuples(PGresult *)" would become "char
> *PQcmdTuples(const PGresult *)".
Both of those return pointers to res->cmdStatus, so it would not make
any sense to const-ify the argument unless you also const-ify the
result; which would cause compiler warnings for users. I'm pretty
sure we've explicitly rejected making this change for that reason.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeroen Vermeulen | 2024-12-21 15:59:03 | Re: libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()? |
| Previous Message | Jeroen Vermeulen | 2024-12-21 12:54:32 | libpq: make PGresult* "const" in PQcmdStatus()/PQcmdTuples()? |