| From: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
|---|---|
| To: | "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> |
| Cc: | "Patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: pg_stat_reset round 2 |
| Date: | 2002-08-05 07:55:17 |
| Message-ID: | 877kj5loyi.fsf@klamath.dyndns.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
"Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au> writes:
> This is a reworked patch. It makes pg_stat_reset() a documented builtin
> function. It requires superuser privileges to execute. The committer
> should check my pg_proc.h entry to make sure I've set isstrict, volatility,
> etc. correctly...
It should be marked volatile (rather than stable), as it has
side-effects.
Wouldn't PG_RETURN_VOID() be more appropriate than returning true?
Cheers,
Neil
--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2002-08-05 08:00:15 | Re: pg_stat_reset round 2 |
| Previous Message | Christopher Kings-Lynne | 2002-08-05 07:25:10 | pg_stat_reset round 2 |