| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | Shigeru HANADA <shigeru(dot)hanada(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink |
| Date: | 2012-07-04 19:41:42 |
| Message-ID: | CA+TgmoYZiayts=FjSytZqLg7REwLWKDkEY5f+fHP5V5_nu_iiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila <amit(dot)kapila(at)huawei(dot)com> wrote:
> Hi Shigeru/Robert,
>
>> The way fixing oid2name and pgbench seems reasonable, so applying it to
>> vacuumlo (as Peter mentioned) would be enough for this issue.
>
> Shall I consider following 2 points to update the patch:
> 1. Apply changes similar to pgbench and oid2name for vacuumlo
> 2. Remove the modifications for dblink.
I've done these two things and committed this. Along the way, I also
fixed it to use a stack-allocated array instead of using malloc, since
there's no need to malloc a fixed-size array with 7 elements.
Thanks for the patch.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-07-04 19:44:41 | Re: User-Id Tracking when Portal was started |
| Previous Message | Boszormenyi Zoltan | 2012-07-04 18:36:08 | Re: [PATCH] lock_timeout and common SIGALRM framework |