From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Documentation improvements for partitioning |
Date: | 2017-03-09 18:26:50 |
Message-ID: | CA+TgmoaS=kSNAMP6LCx=3dZJvoH_K+5zv+qWK-tDqB-PAZ7d9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | Postg사설 토토 사이트SQL |
I think you might have the titles for 0002 and 0003 backwards.
On Fri, Mar 3, 2017 at 2:51 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> 0002: some cosmetic fixes to create_table.sgml
I think this sentence may be unclear to some readers:
+ One might however want to set it for only some partitions,
+ which is possible by doing <literal>SET NOT NULL</literal> on individual
+ partitions.
I think you could replace this with something like: Even if there is
no <literal>NOT NULL</> constraint on the parent, such a constraint
can still be added to individual partitions, if desired; that is, the
children can disallow nulls even if the parent allows them, but not
the other way around.
> 0003: add clarification about NOT NULL constraint on partition columns in
> alter_table.sgml
This is about list-ifying a note, but I think we should try to
de-note-ify it. It's a giant block of text that is not obviously more
noteworthy than the surrounding text; I think <note> should be saved
for things that particularly need to be called out.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-03-09 18:33:27 | Re: PATCH: psql show index with type info |
Previous Message | Sven R. Kunze | 2017-03-09 18:24:37 | Re: SQL/JSON in PostgreSQL |