| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH: optimized DROP of multiple tables within a transaction |
| Date: | 2012-12-30 03:03:42 |
| Message-ID: | CA+Tgmob4RDh20_USdtSSyMnX-F8n9_1HWLOHf2-BaJWARKiY_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 23, 2012 at 8:41 PM, Tomas Vondra <tv(at)fuzzy(dot)cz> wrote:
> Attached is a patch with fixed handling of temporary relations. I've
> chosen to keep the logic in DropRelFileNodeAllBuffers and rather do a
> local copy without the local relations.
This looks pretty good, although it needs some cleanup for coding
style. And I think BSEARCH_LIMIT cuts a bit too broadly as a name for
the constant.
Granted that we can't decide on an exact value for BSEARCH_LIMIT, is
there any data to indicate that 10 is at least an approximately
correct value?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2012-12-30 03:07:45 | Re: buffer assertion tripping under repeat pgbench load |
| Previous Message | Robert Haas | 2012-12-30 02:48:35 | Re: buffer assertion tripping under repeat pgbench load |