| From: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Zhang, Jie" <zhangjie2(at)cn(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [patch] some PQExpBuffer are not destroyed in pg_dump |
| Date: | 2020-04-13 07:51:06 |
| Message-ID: | CA+fd4k49nPyHh3RmzrwFFRjo0woabqL14gg30KkUS75w_+y5wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 7 Apr 2020 at 11:42, Zhang, Jie <zhangjie2(at)cn(dot)fujitsu(dot)com> wrote:
>
> Hi al
>
> In getDefaultACLs function, some PQExpBuffer are not destroy
>
Yes, it looks like an oversight. It's related to the commit
e2090d9d20d809 which is back-patched to 9.6.
The patch looks good to me.
Regards,
--
Masahiko Sawada http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2020-04-13 07:54:01 | Re: pgbench - test whether a variable exists |
| Previous Message | Julien Rouhaud | 2020-04-13 07:40:14 | Re: WAL usage calculation patch |