| From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Karlsson <andreas(at)proxel(dot)se>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Joe Conway <mail(at)joeconway(dot)com> |
| Subject: | Re: Floating point comparison inconsistencies of the geometric types |
| Date: | 2016-07-18 20:54:13 |
| Message-ID: | CAE2gYzxcgkhkMP1oeiQji=CrgJKyq2mM3SSv5hMRBMxA0caidg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
My progress so far is attached as 2 patches. First one introduces an
header file for adt/float.c. Second one refactors the geometric
operations.
I have removed the fuzzy comparison macros all together. It is very
hard to keep some of them and maintain consistency. Many operators
that would benefit from the fuzzy comparison is quite broken at the
moment [1], anyway. I have also made the comparisons safe against NaN
[2].
[1] /message-id/flat/CAE2gYzw_-z%3DV2kh8QqFjenu%3D8MJXzOP44wRW%3DAzzeamrmTT1%3DQ%40mail.gmail.com
[2] /message-id/flat/28685.1468246504%40sss.pgh.pa.us
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-float-header-v01.patch | application/octet-stream | 46.6 KB |
| 0002-geo-ops-fpcomp-v02.patch | application/octet-stream | 244.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2016-07-18 21:30:42 | Re: \timing interval |
| Previous Message | Andres Freund | 2016-07-18 19:53:09 | Re: One process per session lack of sharing |