| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove unused function argument |
| Date: | 2019-10-30 05:51:59 |
| Message-ID: | CALDaNm0O_OwOn7_mRcEw8UCoQ0ssoq2=00-=OMoUWeT+qb1FDg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> The cache_plan argument to ri_PlanCheck has not been used since
> e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it.
>
> That commit said "I left it alone in case there is any future need for
> it" but there hasn't been a need in 7 years, and I find it confusing to
> have an unused function argument without a clear purpose. It would
> trivial to put it back if needed.
>
Code changes looks fine to me.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | imai.yoshikazu@fujitsu.com | 2019-10-30 05:55:28 | RE: [Proposal] Add accumulated statistics |
| Previous Message | imai.yoshikazu@fujitsu.com | 2019-10-30 05:51:11 | RE: [Proposal] Add accumulated statistics |