Re: BUG #13642: no backup_label file in PG_DATA after pg_stop_backup();

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: amir(dot)rohan(at)mail(dot)com
Cc: Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13642: no backup_label file in PG_DATA after pg_stop_backup();
Date: 2015-09-26 03:30:33
Message-ID: CAMkU=1wGQ3nNu8bKJpwtjCjnNUAzAT=nyp4kFXDDk6XfDJL8kg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Sep 25, 2015 at 8:16 PM, <amir(dot)rohan(at)mail(dot)com> wrote:

> The following bug has been logged on the website:
>
> Bug reference: 13642
> Logged by: Amir Rohan
> Email address: amir(dot)rohan(at)mail(dot)com
> PostgreSQL version: 9.4.4
> Operating system: Linux
> Description:
>
> SELECT pg_start_backup('backup1');
> SELECT pg_stop('backup1');
>

The backup_label file should have been created by the first of those, and
removed by the second. It should have existed in $PGDATA between those
events, but not afterward. Because it should have been present in $PGDATA
while it was being copied to the backup, that means it should also be
present in your backup.

>
> Doesn't create the `backup_label` described in the docs (I'm assuming
> "cluster directory" means data directory, e.g. $PGDATA):
> http://www.postgresql.org/docs/current/static/continuous-archiving.html
>
> They further state:
> "The file is critical to the integrity of the backup, should you need to
> restore from it."
>
> Are my backups safe or not?
>
>
Is backup_label present in your *backup*? That is where it is needed. It
is not needed in $PGDATA itself. It is created in $PGDATA simply so that a
copy of it gets included in your backup.

Cheers,

Jeff

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amir Rohan 2015-09-26 06:27:50 Re: BUG #13642: no backup_label file in PG_DATA after pg_stop_backup();
Previous Message amir.rohan 2015-09-26 03:22:47 BUG #13644: 2xRecovery without new writes, causes archiving failure