| From: | Julien Rouhaud <julien(dot)rouhaud(at)free(dot)fr> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Evgeny Efimkin <efimkin(at)yandex-team(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Date: | 2019-08-01 20:49:48 |
| Message-ID: | CAOBaU_bY3Fx+L_HL4x9pK1+9z8rDt49q=twcvrNi-fxpBdnJgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 1, 2019 at 8:36 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2019-08-01 14:20:46 -0400, Robert Haas wrote:
> > However, I think that the fact that this patch adds 15 new calls to
> > pg_atomic_write_u64(&MyProc->queryId, ...) is probably not a good
> > sign. It seems like we ought to be able to centralize it better than
> > that.
>
> +1
Unfortunately I didn't find a better way to do that. Since you can
have nested execution, I don't see how to avoid adding extra code in
every parts of query execution.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-08-01 20:51:59 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Previous Message | Julien Rouhaud | 2019-08-01 20:42:23 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |