Re: SP-GiST for ranges based on 2d-mapping and quad-tree

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SP-GiST for ranges based on 2d-mapping and quad-tree
Date: 2012-09-04 13:45:22
Message-ID: CAPpHfduemSNpt38yJdhUj1kfwERX792QmxyB=iL2=bkHAEwfpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: Postg토토 결과SQL

On Mon, Aug 20, 2012 at 12:25 AM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:

> I am taking a look at this patch now. A few quick comments:
>
> * It looks like bounds_adjacent modifies it's by-reference arguments,
> which is a little worrying to me. The lower/upper labels are flipped
> back, but the inclusivities are not. Maybe just pass by value instead?
>
> * Bounds_adjacent is sensitive to the argument order. Can't it just take
> bound1 and bound2?
>

Fixed. Patch is attached.

------
With best regards,
Alexander Korotkov.

Attachment Content-Type Size
range_spgist_adjacent-0.2.patch.gz application/x-gzip 3.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2012-09-04 13:47:49 Re: 9.2 pg_upgrade regression tests on WIndows
Previous Message Craig Ringer 2012-09-04 13:42:26 Re: Reduce the time to know trigger_fi​le's existence