pg_upgrade in 9.3.5 can not start cluster

Hi,

we've encountered possible bug in debian packages, both squeeze and wheezy seem to be affected.

We're using following repositories:
http://apt.postgresql.org/pub/repos/apt/ squeeze-pgdg/main amd64 Packages
http://apt.postgresql.org/pub/repos/apt/ wheezy-pgdg/main amd64 Packages

This bug makes it currently impossible to run pg_upgrade script on 9.3 and therefore successfully upgrade from 9.2 to 9.3. It seems to be a typo somewhere in the source code. Unfortunately, I don't have the logs anymore, but the problem was that pg_upgrade refused to start cluster with an error that went like 'parameter "full_page_writes" requires a Boolean value'. The problem was that the startup command had a typo in it and contained '-c full_page_writes=off-c anotherparameter...' (Notice no space after =off).

I think the pg_upgrade script worked when we were upgrading from 9.2 to 9.3.4, upgrade from 9.2 to 9.3.5 does not work anymore. As a workaround we have used pg_upgrade from 9.3.4 package and it worked.

Could you guys look at it? Unfortunately due to internal policy I can't test any patches in our environment, but this should be easily reproducible on a clean debian box.

Regards,
Jirka Chadima