| From: | Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: minor fix of elevel in fd.c |
| Date: | 2006-06-13 01:45:14 |
| Message-ID: | Pine.LNX.4.58.0606122143310.27449@eon.cs |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Mon, 12 Jun 2006, Tom Lane wrote:
> "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu> writes:
> > AllocateFile() and AllocateDir() should return the control to the caller
> > since we might want to upgrade the elevel.
>
> That is not what we do for upgrading errors. Use a critical section in
> a caller that doesn't want elog(ERROR).
>
True, but current code just check the return value of AllocateABC() then
decide to upgrade elevel to FATAL. This is ok if we allow AllocateABC()
don't elog(ERROR) themselves.
Regards,
Qingqing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2006-06-13 01:47:45 | Re: minor fix of elevel in fd.c |
| Previous Message | Bruce Momjian | 2006-06-13 01:23:51 | Re: Bitmap index AM |