| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove an unnecessary LSN calculation while validating WAL page header |
| Date: | 2022-10-12 01:00:32 |
| Message-ID: | Y0YRsAqAoUSTUsNH@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 11, 2022 at 06:24:26PM +0200, Alvaro Herrera wrote:
> Knowing how difficult that code was, and how heroic was to change it to
> a more maintainable form, I place no blame on failing to notice that
> some small thing could have been written more easily.
+1. And even after such changes the code is still complex for the
common eye. Anyway, this makes the code a bit simpler with the exact
same maths, so applied.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-12 01:08:24 | Re: Make finding openssl program a configure or meson option |
| Previous Message | Michael Paquier | 2022-10-12 00:13:20 | Re: Query Jumbling for CALL and SET utility statements |