| From: | ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker ) |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition |
| Date: | 2019-11-02 23:14:47 |
| Message-ID: | d8jlfsxq3a0.fsf@dalvik.ping.uio.no |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I just noticed that when contrib/seg was converted to V1 calling
convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
in terms of PG_GETARG_POINTER(). But it itself calls DatumGetPointer(),
so shouldn't it be using PG_GETARG_DATUM()?
Attached is a patch that fixes it, and brings it in line with all the
other PG_GETARG_FOO_P() macros.
- ilmari
--
"A disappointingly low fraction of the human race is,
at any given time, on fire." - Stig Sandbeck Mathisen
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-contrib-seg-Fix-PG_GETARG_SEG_P-definition.patch | text/x-diff | 732 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2019-11-02 23:20:43 | Re: 64 bit transaction id |
| Previous Message | Daniel Gustafsson | 2019-11-02 22:57:06 | Re: Make StringInfo available to frontend code. |