| Lists: | pgsql-bugs |
|---|
| From: | PG Bug reporting form <noreply(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Cc: | muralikrishna(dot)bandaru(at)enterprisedb(dot)com |
| Subject: | BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib |
| Date: | 2024-06-17 05:44:18 |
| Message-ID: | 18513-cf23db54997c9021@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
The following bug has been logged on the website:
Bug reference: 18513
Logged by: Muralikrishna Bandaru
Email address: muralikrishna(dot)bandaru(at)enterprisedb(dot)com
PostgreSQL version: 17beta1
Operating system: Windows
Description:
PG17 build on windows is generating postgres.exe.lib. But all the previous
versions generating postgres.lib file. Due to this renaming the extensions
fail to link with this library by default as they expect postgres.lib. For
example here is the link for system_stats project file
https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101
This seems like a bug, Can some one please confirm?
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | muralikrishna(dot)bandaru(at)enterprisedb(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib |
| Date: | 2024-06-18 06:25:24 |
| Message-ID: | 080afa1e-476b-44f2-b052-4d669c23d290@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On 17.06.24 07:44, PG Bug reporting form wrote:
> The following bug has been logged on the website:
>
> Bug reference: 18513
> Logged by: Muralikrishna Bandaru
> Email address: muralikrishna(dot)bandaru(at)enterprisedb(dot)com
> PostgreSQL version: 17beta1
> Operating system: Windows
> Description:
>
> PG17 build on windows is generating postgres.exe.lib. But all the previous
> versions generating postgres.lib file. Due to this renaming the extensions
> fail to link with this library by default as they expect postgres.lib. For
> example here is the link for system_stats project file
> https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101
>
> This seems like a bug, Can some one please confirm?
The attached patch might fix it. At least I appear to get the right
output file name. I don't have the ability to check whether it does the
right thing on Cygwin.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-meson-Fix-import-library-name-in-Windows.patch | text/plain | 1.7 KB |
| From: | Muralikrishna Bandaru <muralikrishna(dot)bandaru(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib |
| Date: | 2024-06-18 11:32:37 |
| Message-ID: | CA+uec8CNSCLxADk0inov6pRw-nS_E4skV8K2v-UwPo2y9GUf7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On Tue, Jun 18, 2024 at 11:55 AM Peter Eisentraut <peter(at)eisentraut(dot)org>
wrote:
> On 17.06.24 07:44, PG Bug reporting form wrote:
> > The following bug has been logged on the website:
> >
> > Bug reference: 18513
> > Logged by: Muralikrishna Bandaru
> > Email address: muralikrishna(dot)bandaru(at)enterprisedb(dot)com
> > PostgreSQL version: 17beta1
> > Operating system: Windows
> > Description:
> >
> > PG17 build on windows is generating postgres.exe.lib. But all the
> previous
> > versions generating postgres.lib file. Due to this renaming the
> extensions
> > fail to link with this library by default as they expect postgres.lib.
> For
> > example here is the link for system_stats project file
> >
> https://github.com/EnterpriseDB/system_stats/blob/master/system_stats.vcxproj#L101
> >
> > This seems like a bug, Can some one please confirm?
>
> The attached patch might fix it. At least I appear to get the right
> output file name. I don't have the ability to check whether it does the
> right thing on Cygwin.
>
Hi Peter,
This patch worked for me. Now postgres.lib is created instead of
postgres.exe.lib. Once you
push this patch to the source repo then I will try to build the extension
(system_stats).
| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Muralikrishna Bandaru <muralikrishna(dot)bandaru(at)enterprisedb(dot)com> |
| Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18513: PG17 build on windows generates postgres.exe.lib instead of postgres.lib |
| Date: | 2024-06-20 07:23:12 |
| Message-ID: | 92ed8abd-8017-486e-b8f5-e5dfd8701cb6@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
On 18.06.24 13:32, Muralikrishna Bandaru wrote:
> The attached patch might fix it. At least I appear to get the right
> output file name. I don't have the ability to check whether it does
> the
> right thing on Cygwin.
>
> Hi Peter,
> This patch worked for me. Now postgres.lib is created instead of
> postgres.exe.lib. Once you
> push this patch to the source repo then I will try to build the
> extension (system_stats).
committed