message style for errcontext

Lists: pgsql-hackers
From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: message style for errcontext
Date: 2010-05-17 18:20:21
Message-ID: 1274120421.27239.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

We have in 9.0 plperl.c

errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
errcontext("while parsing Perl initialization")));
errcontext("while running Perl initialization")));
errcontext("While executing PLC_TRUSTED.")));
errcontext("While executing utf8fix.")));
errcontext("While executing plperl.on_plperl_init.")));
errcontext("while executing plperl.on_plperlu_init")));

Could we agree on a capitalization and punctuation scheme?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: message style for errcontext
Date: 2010-05-17 18:31:57
Message-ID: 21793.1274121117@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> We have in 9.0 plperl.c
> errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
> errcontext("while parsing Perl initialization")));
> errcontext("while running Perl initialization")));
> errcontext("While executing PLC_TRUSTED.")));
> errcontext("While executing utf8fix.")));
> errcontext("While executing plperl.on_plperl_init.")));
> errcontext("while executing plperl.on_plperlu_init")));

> Could we agree on a capitalization and punctuation scheme?

Instances of errcontext() elsewhere don't use either initcap or
terminating period. I think that's probably good to stick with,
but the message guidelines need to document that these messages
shouldn't follow the "full sentence" style.

regards, tom lane

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: message style for errcontext
Date: 2010-05-17 18:42:45
Message-ID: 4BF18E25.6070904@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut wrote:
> We have in 9.0 plperl.c
>
> errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
> errcontext("while parsing Perl initialization")));
> errcontext("while running Perl initialization")));
> errcontext("While executing PLC_TRUSTED.")));
> errcontext("While executing utf8fix.")));
> errcontext("While executing plperl.on_plperl_init.")));
> errcontext("while executing plperl.on_plperlu_init")));
>
> Could we agree on a capitalization and punctuation scheme?
>

Sure. Sorry about that. Looking at other uses it looks like the most
consistent would be to have no initial cap and no trailing period. I'll
adjust it that way if you like. Is there anything else you want adjusted?

cheers

andrew

From: "David E(dot) Wheeler" <david(at)kineticode(dot)com>
To: pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: errcontext from PL/pgSQL (was message style for errcontext)
Date: 2010-05-17 18:43:25
Message-ID: 8B70FC25-C290-455A-BA5D-4C2A066F4D99@kineticode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On May 17, 2010, at 11:20 AM, Peter Eisentraut wrote:

> We have in 9.0 plperl.c
>
> errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
> errcontext("while parsing Perl initialization")));
> errcontext("while running Perl initialization")));
> errcontext("While executing PLC_TRUSTED.")));
> errcontext("While executing utf8fix.")));
> errcontext("While executing plperl.on_plperl_init.")));
> errcontext("while executing plperl.on_plperlu_init")));
>
> Could we agree on a capitalization and punctuation scheme?

Oh, this reminds me. Is there a way to get at errcontext data from PL/pgSQL? I'm assuming there's something to complement SQLSTATE and SQLERRM, yes?

Thanks,

David