Re: Re: more odbc patches

hi, there!

there is one problem with Zoltan patches commited into the tree:
if we set autocommit off and issued COMMIT (or ROLLBACK) on a connection
new transaction is not started

attached patch should solve this problem (it mostly contains old cruft
removal -- i can send minimal patch if necessary)

/fjoe

hi, there!

On Thu, 14 Dec 2000, Max Khon wrote:

> there is one problem with Zoltan patches commited into the tree:
> if we set autocommit off and issued COMMIT (or ROLLBACK) on a connection
> new transaction is not started
>
> attached patch should solve this problem (it mostly contains old cruft
> removal -- i can send minimal patch if necessary)

sorry, new patch (without compilation warnings)

/fjoe

Are new odbc installs (postdrv.exe) created when there are patches? Aka. we
can uninstall the old driver, download the new one and install it? Or is it
up to us to compile a new driver?

Adam Lang
Systems Engineer
Rutgers Casualty Insurance Company
http://www.rutgersinsurance.com
----- Original Message -----
From: "Max Khon" <fjoe(at)iclub(dot)nsu(dot)ru>
To: <pgsql-interfaces(at)postgresql(dot)org>
Sent: Thursday, December 14, 2000 8:58 AM
Subject: [INTERFACES] more odbc patches

> hi, there!
>
> there is one problem with Zoltan patches commited into the tree:
> if we set autocommit off and issued COMMIT (or ROLLBACK) on a connection
> new transaction is not started
>
> attached patch should solve this problem (it mostly contains old cruft
> removal -- i can send minimal patch if necessary)
>
> /fjoe
>

I'd love to... but unless I can compile it for you in VB, no luck.

Adam Lang
Systems Engineer
Rutgers Casualty Insurance Company
http://www.rutgersinsurance.com
----- Original Message -----
From: "Thomas Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
To: "Adam Lang" <aalang(at)rutgersinsurance(dot)com>
Cc: <pgsql-interfaces(at)postgresql(dot)org>
Sent: Thursday, December 14, 2000 11:08 AM
Subject: Re: [INTERFACES] more odbc patches

> > Are new odbc installs (postdrv.exe) created when there are patches? Aka.
we
> > can uninstall the old driver, download the new one and install it? Or is
it
> > up to us to compile a new driver?
>
> We've been getting some great patches for ODBC recently, but can always
> use a bit more help for posting compiled versions, documentation, etc
> etc.
>
> The server at ftp.postgresql.org is available to anyone wanting to post
> binary packages.
>
> - Thomas

On Thu, 14 Dec 2000, Adam Lang wrote:

> I'd love to... but unless I can compile it for you in VB, no luck.
I'm almost sure you can. Good luck and thanks! Zoltan

> Are new odbc installs (postdrv.exe) created when there are patches? Aka. we
> can uninstall the old driver, download the new one and install it? Or is it
> up to us to compile a new driver?

We've been getting some great patches for ODBC recently, but can always
use a bit more help for posting compiled versions, documentation, etc
etc.

The server at ftp.postgresql.org is available to anyone wanting to post
binary packages.

- Thomas

I can compile the ODBC driver with VB?!?!?

Adam Lang
Systems Engineer
Rutgers Casualty Insurance Company
http://www.rutgersinsurance.com
----- Original Message -----
From: "Kovacs Zoltan Sandor" <tip(at)pc10(dot)radnoti-szeged(dot)sulinet(dot)hu>
To: "Adam Lang" <aalang(at)rutgersinsurance(dot)com>
Cc: <pgsql-interfaces(at)postgresql(dot)org>
Sent: Thursday, December 14, 2000 11:07 AM
Subject: Re: [INTERFACES] more odbc patches

> On Thu, 14 Dec 2000, Adam Lang wrote:
>
> > I'd love to... but unless I can compile it for you in VB, no luck.
> I'm almost sure you can. Good luck and thanks! Zoltan

On Thu, 14 Dec 2000, Adam Lang wrote:

> I can compile the ODBC driver with VB?!?!?
Oh no! I'm sorry! I read VB as VC... of course, you can't... :-( Z.

hehe... you started getting me excited for a moment. :)

Adam Lang
Systems Engineer
Rutgers Casualty Insurance Company
http://www.rutgersinsurance.com
----- Original Message -----
From: "Kovacs Zoltan Sandor" <tip(at)pc10(dot)radnoti-szeged(dot)sulinet(dot)hu>
To: "Adam Lang" <aalang(at)rutgersinsurance(dot)com>
Cc: <pgsql-interfaces(at)postgresql(dot)org>
Sent: Thursday, December 14, 2000 11:17 AM
Subject: Re: [INTERFACES] more odbc patches

> On Thu, 14 Dec 2000, Adam Lang wrote:
>
> > I can compile the ODBC driver with VB?!?!?
> Oh no! I'm sorry! I read VB as VC... of course, you can't... :-( Z.

Applied. Thanks.

> hi, there!
>
> On Thu, 14 Dec 2000, Max Khon wrote:
>
> > there is one problem with Zoltan patches commited into the tree:
> > if we set autocommit off and issued COMMIT (or ROLLBACK) on a connection
> > new transaction is not started
> >
> > attached patch should solve this problem (it mostly contains old cruft
> > removal -- i can send minimal patch if necessary)
>
> sorry, new patch (without compilation warnings)
>
> /fjoe
Content-Description:

[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

hi, there!

how about this?

--- cut here ---
>From cs(at)plesk(dot)com Sat Dec 16 15:08:40 2000
Date: Thu, 14 Dec 2000 17:00:43 +0600 (NOVT)
From: Constantin S. Svintsoff <cs(at)plesk(dot)com>
To: fjoe(at)iclub(dot)nsu(dot)ru
Subject: Bug in SQLForeignKeys()

Query used for checking foreign key triggers
returns too many results when there're more than one foreign
key in a table. It happens because only table's oid is used to
link between pg_trigger with INSERT check and pg_trigger with
UPDATE/DELETE check.

I think there should be enough to add following conditions
into WHERE clause of that query:
AND pt.tgconstrname = pg_trigger.tgconstrname
AND pt.tgconstrname = pg_trigger_1.tgconstrname

/Constantin
--- cut here ---

/fjoe

I'm having trouble with connecting to db. I created user and password by
creatuser and pg_passwd, and have line in my pg_hba.conf

#####
local all password passwd
host all 127.0.0.1 255.255.255.255 password passwd
#####

passwd is file create to have password.
now when i try to connect to db by

#####
DriverManager.getConnection("jdbc:postgresql:test",user,pass);
#####

I get the following error messg,

#####
The backend has broken the connection. Possibly the action you have
attempted has caused it to close.
#####

i don't know what is causing to get this error anyone have any idea?

katsu

Katsuyuki Tanaka <katsut(at)cse(dot)unsw(dot)EDU(dot)AU> writes:
> I get the following error messg,
> #####
> The backend has broken the connection. Possibly the action you have
> attempted has caused it to close.
> #####

That's a pretty content-free message, isn't it :-(

There might be more information in the postmaster log. Make sure
you are saving a postmaster log (postmaster should be started without
-S switch, and with stdout and stderr routed to some logfile), and
then see what gets appended to the log when you try to connect.

regards, tom lane

Can someone comment on this?

> hi, there!
>
> how about this?
>
> --- cut here ---
> >From cs(at)plesk(dot)com Sat Dec 16 15:08:40 2000
> Date: Thu, 14 Dec 2000 17:00:43 +0600 (NOVT)
> From: Constantin S. Svintsoff <cs(at)plesk(dot)com>
> To: fjoe(at)iclub(dot)nsu(dot)ru
> Subject: Bug in SQLForeignKeys()
>
>
> Query used for checking foreign key triggers
> returns too many results when there're more than one foreign
> key in a table. It happens because only table's oid is used to
> link between pg_trigger with INSERT check and pg_trigger with
> UPDATE/DELETE check.
>
> I think there should be enough to add following conditions
> into WHERE clause of that query:
> AND pt.tgconstrname = pg_trigger.tgconstrname
> AND pt.tgconstrname = pg_trigger_1.tgconstrname
>
> /Constantin
> --- cut here ---
>
> /fjoe
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

hi, there!

On Mon, 22 Jan 2001, Bruce Momjian wrote:

> Can someone comment on this?

I have got more comments from Constantin: current implementation will fail
(return too many rows) if one table has two foreign keys, e.g.:
CREATE TABLE prim(i integer PRIMARY KEY);
CREATE TABLE f(i integer REFERENCES prim, j integer REFERENCES prim);

> > how about this?
> >
> > --- cut here ---
> > >From cs(at)plesk(dot)com Sat Dec 16 15:08:40 2000
> > Date: Thu, 14 Dec 2000 17:00:43 +0600 (NOVT)
> > From: Constantin S. Svintsoff <cs(at)plesk(dot)com>
> > To: fjoe(at)iclub(dot)nsu(dot)ru
> > Subject: Bug in SQLForeignKeys()
> >
> >
> > Query used for checking foreign key triggers
> > returns too many results when there're more than one foreign
> > key in a table. It happens because only table's oid is used to
> > link between pg_trigger with INSERT check and pg_trigger with
> > UPDATE/DELETE check.
> >
> > I think there should be enough to add following conditions
> > into WHERE clause of that query:
> > AND pt.tgconstrname = pg_trigger.tgconstrname
> > AND pt.tgconstrname = pg_trigger_1.tgconstrname
> >
> > /Constantin
> > --- cut here ---

/fjoe

I don't get it. Does this mean the ODBC driver is checking referential
integrity before it passes things to the backend server? Seems kind of
pointless to me. I thought the ODBC driver just passes through RI errors
generated by the backend.

-Cedar

On Tue, 23 Jan 2001, Max Khon wrote:

> hi, there!
>
> On Mon, 22 Jan 2001, Bruce Momjian wrote:
>
> > Can someone comment on this?
>
> I have got more comments from Constantin: current implementation will fail
> (return too many rows) if one table has two foreign keys, e.g.:
> CREATE TABLE prim(i integer PRIMARY KEY);
> CREATE TABLE f(i integer REFERENCES prim, j integer REFERENCES prim);

hi, there!

On Tue, 23 Jan 2001, Cedar Cox wrote:

> I don't get it. Does this mean the ODBC driver is checking referential
> integrity before it passes things to the backend server? Seems kind of
> pointless to me. I thought the ODBC driver just passes through RI errors
> generated by the backend.

we talk about SQLForeignKeys functionality :)
it has nothing to do with RI errors reporting

> On Tue, 23 Jan 2001, Max Khon wrote:
>
> > hi, there!
> >
> > On Mon, 22 Jan 2001, Bruce Momjian wrote:
> >
> > > Can someone comment on this?
> >
> > I have got more comments from Constantin: current implementation will fail
> > (return too many rows) if one table has two foreign keys, e.g.:
> > CREATE TABLE prim(i integer PRIMARY KEY);
> > CREATE TABLE f(i integer REFERENCES prim, j integer REFERENCES prim);

/fjoe

I have applied the following diff to ODBC to fix the problem, as
Constantin suggested. Would some ODBC folks please test this and make
sure it works?

> hi, there!
>
> how about this?
>
> --- cut here ---
> >From cs(at)plesk(dot)com Sat Dec 16 15:08:40 2000
> Date: Thu, 14 Dec 2000 17:00:43 +0600 (NOVT)
> From: Constantin S. Svintsoff <cs(at)plesk(dot)com>
> To: fjoe(at)iclub(dot)nsu(dot)ru
> Subject: Bug in SQLForeignKeys()
>
>
> Query used for checking foreign key triggers
> returns too many results when there're more than one foreign
> key in a table. It happens because only table's oid is used to
> link between pg_trigger with INSERT check and pg_trigger with
> UPDATE/DELETE check.
>
> I think there should be enough to add following conditions
> into WHERE clause of that query:
> AND pt.tgconstrname = pg_trigger.tgconstrname
> AND pt.tgconstrname = pg_trigger_1.tgconstrname
>
> /Constantin
> --- cut here ---
>
> /fjoe
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Sorry, here is the correct patch.

> hi, there!
>
> how about this?
>
> --- cut here ---
> >From cs(at)plesk(dot)com Sat Dec 16 15:08:40 2000
> Date: Thu, 14 Dec 2000 17:00:43 +0600 (NOVT)
> From: Constantin S. Svintsoff <cs(at)plesk(dot)com>
> To: fjoe(at)iclub(dot)nsu(dot)ru
> Subject: Bug in SQLForeignKeys()
>
>
> Query used for checking foreign key triggers
> returns too many results when there're more than one foreign
> key in a table. It happens because only table's oid is used to
> link between pg_trigger with INSERT check and pg_trigger with
> UPDATE/DELETE check.
>
> I think there should be enough to add following conditions
> into WHERE clause of that query:
> AND pt.tgconstrname = pg_trigger.tgconstrname
> AND pt.tgconstrname = pg_trigger_1.tgconstrname
>
> /Constantin
> --- cut here ---
>
> /fjoe
>
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

On Tue, 23 Jan 2001, Bruce Momjian wrote:

> I have applied the following diff to ODBC to fix the problem, as
> Constantin suggested. Would some ODBC folks please test this and make
> sure it works?

I'd be happy to, but I need a little help :) First of all, do all these
changes I keep seeing have to do with both unix ODBC and windows ODBC? I
don't have a compiler in windows. Is anyone posting compiled versions for
people like me to try out? Lastly, what is it that I'm checking? I
obviously need to learn something about SQLForeignKeys. As far as I knew,
anything that had to do with foreign keys was RI. Simple explanation?, or
link to some reading material?

Thanks,
-Cedar