Re: START TRANSACTION

The attached patch implements START TRANSACTION, per SQL99. The
functionality of the command is basically identical to that of
BEGIN; it just accepts a few extra options (only one of which
PostgreSQL currently implements), and is standards-compliant.
The patch includes a simple regression test and documentation.

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC

On Sat, Jul 27, 2002 at 04:05:20PM -0400, Neil Conway wrote:
> The attached patch implements START TRANSACTION, per SQL99.

Oh, forgot to mention two things: I also removed the grammar's
"support" for chained transactions, since it was basically non-
existent (I don't see the advantage of producing an "chained
transactions not support" error rather than a generic one).
I also renamed the 'opt_level' production to 'iso_level', since
it's not "optional".

Cheers,

Neil

--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Neil Conway wrote:
> The attached patch implements START TRANSACTION, per SQL99. The
> functionality of the command is basically identical to that of
> BEGIN; it just accepts a few extra options (only one of which
> PostgreSQL currently implements), and is standards-compliant.
> The patch includes a simple regression test and documentation.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Neil Conway writes:

> The attached patch implements START TRANSACTION, per SQL99. The
> functionality of the command is basically identical to that of
> BEGIN; it just accepts a few extra options (only one of which
> PostgreSQL currently implements), and is standards-compliant.
> The patch includes a simple regression test and documentation.

Very nice patch, but I don't think we need the regression test. It's a
bit too simple.

--
Peter Eisentraut peter_e(at)gmx(dot)net

Peter Eisentraut wrote:
> Neil Conway writes:
>
> > The attached patch implements START TRANSACTION, per SQL99. The
> > functionality of the command is basically identical to that of
> > BEGIN; it just accepts a few extra options (only one of which
> > PostgreSQL currently implements), and is standards-compliant.
> > The patch includes a simple regression test and documentation.
>
> Very nice patch, but I don't think we need the regression test. It's a
> bit too simple.

Roger.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Peter Eisentraut dijo:

> Neil Conway writes:
>
> > The attached patch implements START TRANSACTION, per SQL99. The
> > functionality of the command is basically identical to that of
> > BEGIN; it just accepts a few extra options (only one of which
> > PostgreSQL currently implements), and is standards-compliant.
> > The patch includes a simple regression test and documentation.
>
> Very nice patch, but I don't think we need the regression test. It's a
> bit too simple.

That makes me wonder: should I produce some regression tests for
CLUSTER?

--
Alvaro Herrera (<alvherre[a]atentus.com>)
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)

[ Regression test removed, per Peter.]

Patch applied. Thanks.

---------------------------------------------------------------------------

Neil Conway wrote:
> The attached patch implements START TRANSACTION, per SQL99. The
> functionality of the command is basically identical to that of
> BEGIN; it just accepts a few extra options (only one of which
> PostgreSQL currently implements), and is standards-compliant.
> The patch includes a simple regression test and documentation.
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> That makes me wonder: should I produce some regression tests for
> CLUSTER?

It'd be a good thing.

regards, tom lane

Tom Lane dijo:

> Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> > That makes me wonder: should I produce some regression tests for
> > CLUSTER?
>
> It'd be a good thing.

I'm attaching cluster.sql and cluster.out to be added to the regression
tests.

--
Alvaro Herrera (<alvherre[a]atentus.com>)
"In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth.
That's because in Europe they call me by name, and in the US by value!"