Re: Earth Distance patch

The attached patch defines functions for getting distances between points
on the surface of the earth and locating points within a specified distance
using an index based on the contrib/cube package. The new functions are
all of language type sql.
A couple of bugs in the old earthdistance function based on the point
datatype are fixed.
A regression test has been added for both sets of functions.
The README file has been updated to include documentation on the new stuff.
There are comments about how this package is also useful for Astronomers.

Bruno Wolff III <bruno(at)wolff(dot)to> writes:
> The attached patch defines functions for getting distances between points
> on the surface of the earth and locating points within a specified distance
> using an index based on the contrib/cube package. The new functions are
> all of language type sql.

Is this bug fix, or new features? We are past the point of accepting
new features for 7.3.

regards, tom lane

On Thu, Sep 12, 2002 at 10:35:49 -0400,
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Bruno Wolff III <bruno(at)wolff(dot)to> writes:
> > The attached patch defines functions for getting distances between points
> > on the surface of the earth and locating points within a specified distance
> > using an index based on the contrib/cube package. The new functions are
> > all of language type sql.
>
> Is this bug fix, or new features? We are past the point of accepting
> new features for 7.3.

Some of both.

I found some bugs in the original earthdistance code while trying to make
up regression tests.

If you would like I can split this. I can submit the bug fixes and a regression
test for the old stuff. And then after 7.3 comes out, resubmit the additional
documentation, functions (all of language type sql) and regression tests.

This was the email that prompted the second, smaller page. Do we
feature freeze beta?

---------------------------------------------------------------------------

Bruno Wolff III wrote:
> On Thu, Sep 12, 2002 at 10:35:49 -0400,
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Bruno Wolff III <bruno(at)wolff(dot)to> writes:
> > > The attached patch defines functions for getting distances between points
> > > on the surface of the earth and locating points within a specified distance
> > > using an index based on the contrib/cube package. The new functions are
> > > all of language type sql.
> >
> > Is this bug fix, or new features? We are past the point of accepting
> > new features for 7.3.
>
> Some of both.
>
> I found some bugs in the original earthdistance code while trying to make
> up regression tests.
>
> If you would like I can split this. I can submit the bug fixes and a regression
> test for the old stuff. And then after 7.3 comes out, resubmit the additional
> documentation, functions (all of language type sql) and regression tests.
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

This has been saved for the 7.4 release:

http://candle.pha.pa.us/cgi-bin/pgpatches2

We will apply only the non-7.3 stuff. In fact, I will probably just get
back to you on this during 7.4 or you will submit a new one.

---------------------------------------------------------------------------

Bruno Wolff III wrote:
> The attached patch defines functions for getting distances between points
> on the surface of the earth and locating points within a specified distance
> using an index based on the contrib/cube package. The new functions are
> all of language type sql.
> A couple of bugs in the old earthdistance function based on the point
> datatype are fixed.
> A regression test has been added for both sets of functions.
> The README file has been updated to include documentation on the new stuff.
> There are comments about how this package is also useful for Astronomers.

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

On Wed, Sep 18, 2002 at 00:40:27 -0400,
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
>
> This has been saved for the 7.4 release:
>
> http://candle.pha.pa.us/cgi-bin/pgpatches2
>
> We will apply only the non-7.3 stuff. In fact, I will probably just get
> back to you on this during 7.4 or you will submit a new one.

That is fine.

There may be better ways to handle that contrib than putting it with
earthdistance. Most people aren't going to want both at the same time (as one
uses point and the other uses cube).

I have applied your patch by pickout out the pieces that were already
not in CVS. Thanks.

---------------------------------------------------------------------------

Bruno Wolff III wrote:
> The attached patch defines functions for getting distances between points
> on the surface of the earth and locating points within a specified distance
> using an index based on the contrib/cube package. The new functions are
> all of language type sql.
> A couple of bugs in the old earthdistance function based on the point
> datatype are fixed.
> A regression test has been added for both sets of functions.
> The README file has been updated to include documentation on the new stuff.
> There are comments about how this package is also useful for Astronomers.

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073