Fixes for autocommit = off

Lists: pgsql-patches
From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Fixes for autocommit = off
Date: 2002-10-16 05:52:56
Message-ID: 200210160552.g9G5quV08884@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Here are some patches I applied that attempt to fix some of our
utilities for the 'autocommit = off' world. I still need to do more
work.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 17.9 KB
From: Joe Conway <mail(at)joeconway(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fixes for autocommit = off
Date: 2002-10-16 06:10:03
Message-ID: 3DAD02BB.1060309@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Bruce Momjian wrote:
> Here are some patches I applied that attempt to fix some of our
> utilities for the 'autocommit = off' world. I still need to do more
> work.

Speaking of autocommit = off, I was contemplating sending in a patch for
dblink with this in it:

appendStringInfo(str,
"BEGIN;SET autocommit='on';COMMIT; %s",
GET_STR(PG_GETARG_TEXT_P(1)));

(where arg 1 is the user provided sql statement) to cover the non-persistent
connection case for dblink_exec. Is this the recommended client fix?

Joe

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fixes for autocommit = off
Date: 2002-10-16 14:10:01
Message-ID: 24000.1034777401@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: Postg토토 캔SQL :

Joe Conway <mail(at)joeconway(dot)com> writes:
> Speaking of autocommit = off, I was contemplating sending in a patch for
> dblink with this in it:
> appendStringInfo(str,
> "BEGIN;SET autocommit='on';COMMIT; %s",
> GET_STR(PG_GETARG_TEXT_P(1)));
> (where arg 1 is the user provided sql statement) to cover the non-persistent
> connection case for dblink_exec. Is this the recommended client fix?

You do not need the begin/commit here.

A bigger question is why dblink should be doing that at all... seems
like it should be the programmer's responsibility.

regards, tom lane